http://codereview.chromium.org/159787/diff/1005/4 File include/v8.h (right):
http://codereview.chromium.org/159787/diff/1005/4#newcode1973 Line 1973: * kinds of heap profiling. Each can be turned on / off independently. On 2009/08/04 13:44:55, Søren Gjesse wrote: > Please add a comment on PROFILER_MODULE_HEAP_SNAPSHOT. Done. http://codereview.chromium.org/159787/diff/1005/5 File src/api.cc (right): http://codereview.chromium.org/159787/diff/1005/5#newcode3246 Line 3246: flags &= ~PROFILER_MODULE_HEAP_SNAPSHOT; On 2009/08/04 13:44:55, Søren Gjesse wrote: > Should PROFILER_MODULE_CPU be masked out here as well? What is the exact > semantics of combining PROFILER_MODULE_CPU and PROFILER_MODULE_HEAP_SNAPSHOT? Combining CPU profiling with snapshot makes no sense to me. Added masking for it. http://codereview.chromium.org/159787 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
