https://codereview.chromium.org/389573006/diff/1/src/api.cc
File src/api.cc (right):
https://codereview.chromium.org/389573006/diff/1/src/api.cc#newcode1755
src/api.cc:1755: script_data != NULL) {
On 2014/07/14 10:40:04, vogelheim wrote:
On 2014/07/14 07:45:46, marja wrote:
> I don't think it's possible that (options == kProduceParserCache ||
options ==
> kProduceCodeCache) and script_data == NULL, so that part of the if
is
> unnecessary.
Well... if any kProduce*Cache is set and Compiler::CompileScript
returns an
empty reference, then the script_data will be deleted just above. The
comment
above suggests this doesn't happen in normal operation, but apparently
in can
happen in tests?
Ahh, I missed the if above which actually does nullify it. My comment is
obsolete.
https://codereview.chromium.org/389573006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
