LGTM, only nits
https://codereview.chromium.org/382893003/diff/1/src/objects.h
File src/objects.h (right):
https://codereview.chromium.org/382893003/diff/1/src/objects.h#newcode7279
src/objects.h:7279: // Indicated that this function is an arrow
function.
s/Indiciated/Indicates/
https://codereview.chromium.org/382893003/diff/1/src/v8natives.js
File src/v8natives.js (right):
https://codereview.chromium.org/382893003/diff/1/src/v8natives.js#newcode1737
src/v8natives.js:1737: return source;
Nit: please use same brace style as surrounding code
https://codereview.chromium.org/382893003/diff/1/test/cctest/test-parsing.cc
File test/cctest/test-parsing.cc (right):
https://codereview.chromium.org/382893003/diff/1/test/cctest/test-parsing.cc#newcode256
test/cctest/test-parsing.cc:256: NULL
Nit: Don't use NULL, use the ARRAY_SIZE macro instead.
https://codereview.chromium.org/382893003/diff/1/test/mjsunit/harmony/arrow-functions.js
File test/mjsunit/harmony/arrow-functions.js (right):
https://codereview.chromium.org/382893003/diff/1/test/mjsunit/harmony/arrow-functions.js#newcode9
test/mjsunit/harmony/arrow-functions.js:9: assertEquals(typeof (() =>
{}), "function");
Nit: expected value should go left (similarly below a few times).
https://codereview.chromium.org/382893003/diff/1/test/mjsunit/harmony/arrow-functions.js#newcode46
test/mjsunit/harmony/arrow-functions.js:46: [1, 2, 3, 4, 5, 6, 7, 8, 9,
10].forEach(v => { if (v % 5 === 0) fives.push(v); });
Nit: line length
https://codereview.chromium.org/382893003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
