On 2014/07/14 13:54:03, Michael Starzinger wrote:
On 2014/07/14 13:45:16, ernstm wrote:
> On 2014/07/14 12:04:31, Michael Starzinger wrote:
> > We can perform multiple scavenges while the incremental marker (and
hence
a
> > mark-and-compact GC) is still in progress. Has this been taken into
account?
> How
> > will this affect the numbers tracked by the persistent GCTracer?
>
> This patch shouldn't change the numbers, unless I missed something. The
new
> start
> and stop methods implement the functionality previously found in the
> constructor and destructor of GCTracer. The incremental marking step
counters
> are now
> tracked directly in GCTracer, instead of copying them from
IncrementalMarking
in
> the constructor.
Yes, the mechanics of which numbers are gathered where didn't change. But
the
change in line 1107 of heap.cc no longer installs a different GCTracer
object
for the scavenge operation. Instead the GCTracer object for a
mark-and-compact
GC is shared with the one for a scavenge operation. So the statistics
gathered
while scavenging are gathered on top of any running mark-and-compact
operation.
Got it. I assumed that there was no overlap between what is traced in
Scavenge()
and MarkCompact(). The overlap makes it difficult to use a single GCTracer.
https://codereview.chromium.org/390823003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
