[v8-dev] Remove ASSERT since there are tons of different ASSIGN variants (issue 385173009 by verwaest@chromium.org)

[verwaest]

Reviewers: rossberg,

Message:
PTAL
Description:
Remove ASSERT since there are tons of different ASSIGN variants

BUG=

Please review this at https://codereview.chromium.org/385173009/

SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge

Affected files (+0, -8 lines):
  M src/arm/full-codegen-arm.cc
  M src/arm64/full-codegen-arm64.cc
  M src/ia32/full-codegen-ia32.cc
  M src/x64/full-codegen-x64.cc


Index: src/arm/full-codegen-arm.cc
diff --git a/src/arm/full-codegen-arm.cc b/src/arm/full-codegen-arm.cc
index  
e64b40f7ddf087ca022fba2b97f37739e866bff6..ede1230df3c21de53f8d9ddb9bf7abe1c3c6345c  
100644
--- a/src/arm/full-codegen-arm.cc
+++ b/src/arm/full-codegen-arm.cc
@@ -2502,8 +2502,6 @@ void  
FullCodeGenerator::EmitVariableAssignment(Variable* var, Token::Value op) {

   } else if (!var->is_const_mode() || op == Token::INIT_CONST) {
     if (var->IsLookupSlot()) {
-      ASSERT(op == Token::ASSIGN || op == Token::INIT_VAR ||
-             op == Token::ASSIGN_ADD);
       // Assignment to var.
       __ push(r0);  // Value.
       __ mov(r1, Operand(var->name()));
Index: src/arm64/full-codegen-arm64.cc
diff --git a/src/arm64/full-codegen-arm64.cc  
b/src/arm64/full-codegen-arm64.cc
index  
b3539e635daeb2c078e98d98cae4b8cb2d77f5f7..76759169e54e6e113766a2737c2650397ed64704  
100644
--- a/src/arm64/full-codegen-arm64.cc
+++ b/src/arm64/full-codegen-arm64.cc
@@ -2185,8 +2185,6 @@ void  
FullCodeGenerator::EmitVariableAssignment(Variable* var,

   } else if (!var->is_const_mode() || op == Token::INIT_CONST) {
     if (var->IsLookupSlot()) {
-      ASSERT(op == Token::ASSIGN || op == Token::INIT_VAR ||
-             op == Token::ASSIGN_ADD);
       // Assignment to var.
       __ Mov(x11, Operand(var->name()));
       __ Mov(x10, Smi::FromInt(strict_mode()));
Index: src/ia32/full-codegen-ia32.cc
diff --git a/src/ia32/full-codegen-ia32.cc b/src/ia32/full-codegen-ia32.cc
index  
8ab2d3017ff9405f272d008dbb0e4fa7fcd01622..0dc3254921bbf99ad586a41530c770303101550b  
100644
--- a/src/ia32/full-codegen-ia32.cc
+++ b/src/ia32/full-codegen-ia32.cc
@@ -2428,8 +2428,6 @@ void  
FullCodeGenerator::EmitVariableAssignment(Variable* var,

   } else if (!var->is_const_mode() || op == Token::INIT_CONST) {
     if (var->IsLookupSlot()) {
-      ASSERT(op == Token::ASSIGN || op == Token::INIT_VAR ||
-             op == Token::ASSIGN_ADD);
       // Assignment to var.
       __ push(eax);  // Value.
       __ push(esi);  // Context.
Index: src/x64/full-codegen-x64.cc
diff --git a/src/x64/full-codegen-x64.cc b/src/x64/full-codegen-x64.cc
index  
625ce1a0e9ac485b81cf5f4a82b63c0e24a8342e..1b338481bb95ce05bf36c39e7a35b3d7bb171d8a  
100644
--- a/src/x64/full-codegen-x64.cc
+++ b/src/x64/full-codegen-x64.cc
@@ -2426,8 +2426,6 @@ void  
FullCodeGenerator::EmitVariableAssignment(Variable* var,

   } else if (!var->is_const_mode() || op == Token::INIT_CONST) {
     if (var->IsLookupSlot()) {
-      ASSERT(op == Token::ASSIGN || op == Token::INIT_VAR ||
-             op == Token::ASSIGN_ADD);
       // Assignment to var.
       __ Push(rax);  // Value.
       __ Push(rsi);  // Context.


--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
--- 
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.