Reviewers: Jakob,
Message:
PTAL
Description:
Properly escape benchmark names when retrieving results.
This allows benchmarks to contain regular expression characters in their
name.
BUG=
Please review this at https://codereview.chromium.org/396203003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+2, -2 lines):
M tools/run_benchmarks.py
Index: tools/run_benchmarks.py
diff --git a/tools/run_benchmarks.py b/tools/run_benchmarks.py
index
4c72eeb8679e8102d8315aa251ba8c33b151f1c7..d6e9145dacea3bdf73062d5fa88954d5b807bdd8
100755
--- a/tools/run_benchmarks.py
+++ b/tools/run_benchmarks.py
@@ -192,14 +192,14 @@ class Graph(Node):
# TODO(machenbach): Currently that makes only sense for the leaf level.
# Multiple place holders for multiple levels are not supported.
if parent.results_regexp:
- regexp_default = parent.results_regexp % suite["name"]
+ regexp_default = parent.results_regexp % re.escape(suite["name"])
else:
regexp_default = None
self.results_regexp = suite.get("results_regexp", regexp_default)
# A similar regular expression for the standard deviation (optional).
if parent.stddev_regexp:
- stddev_default = parent.stddev_regexp % suite["name"]
+ stddev_default = parent.stddev_regexp % re.escape(suite["name"])
else:
stddev_default = None
self.stddev_regexp = suite.get("stddev_regexp", stddev_default)
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
