lgtm
https://codereview.chromium.org/385163005/diff/1/src/flag-definitions.h
File src/flag-definitions.h (right):
https://codereview.chromium.org/385163005/diff/1/src/flag-definitions.h#newcode461
src/flag-definitions.h:461: DEFINE_INT(stack_size, 984,
On 2014/07/11 16:39:23, rmcilroy wrote:
Note: this could be lower for 32bit, but I would still need to be
larger than
512KB, which would mean that 64bit would be larger than 1MB if
calculated based
on kPointerSize, so I have just set it to be the same as the existing
64bit
limit. Let me know if you would prefer it set differently.
I guess it is fine, I do not have a strong opinion there.
https://codereview.chromium.org/385163005/diff/1/src/spaces.cc
File src/spaces.cc (right):
https://codereview.chromium.org/385163005/diff/1/src/spaces.cc#newcode3065
src/spaces.cc:3065: // strings), fixed arrays, byte arrays and constant
pool arrays in the
"," before and
https://codereview.chromium.org/385163005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
