https://codereview.chromium.org/398513005/diff/10001/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/398513005/diff/10001/src/runtime.cc#newcode1722
src/runtime.cc:1722: entries->set(number_of_non_hole_elements * 2,
*key);
maybe get rid of multiplications?
entries->set(index++, ...);
entries->set(index++, ...);
https://codereview.chromium.org/398513005/diff/10001/src/runtime.cc#newcode1728
src/runtime.cc:1728: return
*isolate->factory()->NewJSArrayWithElements(entries);
is it guaranteed that (table->NumberOfElements() * 2 ==
number_of_non_hole_elements) here? maybe an ASSERT?
https://codereview.chromium.org/398513005/diff/10001/test/mjsunit/harmony/mirror-collections.js
File test/mjsunit/harmony/mirror-collections.js (right):
https://codereview.chromium.org/398513005/diff/10001/test/mjsunit/harmony/mirror-collections.js#newcode61
test/mjsunit/harmony/mirror-collections.js:61: function
testWeakMapMirrorBeforeGC(mirror) {
could you extract a method out of these two?
https://codereview.chromium.org/398513005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
