Looks good, go ahead and port.
https://codereview.chromium.org/398053002/diff/60001/src/ast.cc File src/ast.cc (right): https://codereview.chromium.org/398053002/diff/60001/src/ast.cc#newcode1104 src/ast.cc:1104: DONT_OPTIMIZE_NODE_WITH_FEEDBACK_SLOTS(Yield) Some sorting would be nice... https://codereview.chromium.org/398053002/diff/60001/src/flag-definitions.h File src/flag-definitions.h (right): https://codereview.chromium.org/398053002/diff/60001/src/flag-definitions.h#newcode219 src/flag-definitions.h:219: DEFINE_bool(vector_ics, true, "support vector-based ics") false? https://codereview.chromium.org/398053002/diff/60001/src/hydrogen-instructions.h File src/hydrogen-instructions.h (right): https://codereview.chromium.org/398053002/diff/60001/src/hydrogen-instructions.h#newcode5409 src/hydrogen-instructions.h:5409: ASSERT(FLAG_vector_ics && slot_ != -1); != kInvalidFeedbackSlot https://codereview.chromium.org/398053002/diff/60001/src/hydrogen-instructions.h#newcode5432 src/hydrogen-instructions.h:5432: slot_(-1) { kInvalidFeedbackSlot https://codereview.chromium.org/398053002/diff/60001/src/hydrogen-instructions.h#newcode6409 src/hydrogen-instructions.h:6409: ASSERT(FLAG_vector_ics && slot_ != -1); kInvalidFeedbackSlot https://codereview.chromium.org/398053002/diff/60001/src/hydrogen-instructions.h#newcode6428 src/hydrogen-instructions.h:6428: slot_(-1) { kInvalidFeedbackSlot https://codereview.chromium.org/398053002/ -- -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
