https://codereview.chromium.org/398333002/diff/60001/src/mark-compact.cc
File src/mark-compact.cc (right):
https://codereview.chromium.org/398333002/diff/60001/src/mark-compact.cc#newcode3237
src/mark-compact.cc:3237: return space->Free(start, size);
On 2014/07/18 08:31:29, jarin wrote:
Could we ASSERT(free_list == NULL) here?
Done.
https://codereview.chromium.org/398333002/diff/60001/src/mark-compact.cc#newcode4130
src/mark-compact.cc:4130: space->set_swept_precisely(sweeper ==
PRECISE);
On 2014/07/18 08:31:29, jarin wrote:
I think the flag should be also set if sweeper is CONCURRENT_PRECISE
or
PARALLEL_PRECISE.
Good catch! Done.
https://codereview.chromium.org/398333002/diff/60001/src/mark-compact.cc#newcode4289
src/mark-compact.cc:4289: if (sweep_precisely_) how_to_sweep = PRECISE;
On 2014/07/18 08:31:29, jarin wrote:
I am wondering whether we want sweep in parallel here (and also in the
spaces
below).
I will address this comment in a separate cl.
https://codereview.chromium.org/398333002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
