Reviewers: Jakob,
Message:
PTAL, thanks.
Description:
Move android_webview_build variable to toolchain.gypi to fix arm builders.
Please review this at https://codereview.chromium.org/392033005/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+6, -3 lines):
M build/android.gypi
M build/toolchain.gypi
Index: build/android.gypi
diff --git a/build/android.gypi b/build/android.gypi
index
e5b87198097646058064c22ecfe320f81b02610d..87bdbcb4ddda644f4f2e5782718712aed2c5744b
100644
--- a/build/android.gypi
+++ b/build/android.gypi
@@ -35,9 +35,6 @@
'variables': {
'android_ndk_root%': '<!(/bin/echo -n $ANDROID_NDK_ROOT)',
'android_toolchain%': '<!(/bin/echo -n $ANDROID_TOOLCHAIN)',
- # This is set when building the Android WebView inside the Android
build
- # system, using the 'android' gyp backend.
- 'android_webview_build%': 0,
},
'conditions': [
['android_ndk_root==""', {
Index: build/toolchain.gypi
diff --git a/build/toolchain.gypi b/build/toolchain.gypi
index
8c6df83549d8e4544cc5e73ec2671bcda18eb391..f2847c5627b90e8cb80b6bd6b06f0b6ff8068463
100644
--- a/build/toolchain.gypi
+++ b/build/toolchain.gypi
@@ -82,6 +82,12 @@
# Allow to suppress the array bounds warning (default is no
suppression).
'wno_array_bounds%': '',
+
+ 'variables': {
+ # This is set when building the Android WebView inside the Android
build
+ # system, using the 'android' gyp backend.
+ 'android_webview_build%': 0,
+ }
},
'conditions': [
['host_arch=="ia32" or host_arch=="x64" or clang==1', {
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
