LGTM. Nice unification!
https://codereview.chromium.org/409613002/diff/1/src/heap-snapshot-generator.cc
File src/heap-snapshot-generator.cc (right):
https://codereview.chromium.org/409613002/diff/1/src/heap-snapshot-generator.cc#newcode1502
src/heap-snapshot-generator.cc:1502: "(%s code)", CodeStub::MajorName(
nit: consider pulling out a temp variable or two to make indentation a
bit less ugly. (But we can also leave it as is if it doesn't bother you;
clang-format is always right.)
https://codereview.chromium.org/409613002/diff/1/src/objects.h
File src/objects.h (right):
https://codereview.chromium.org/409613002/diff/1/src/objects.h#newcode5892
src/objects.h:5892: static const int kSafepointTableOffsetBitCount = 24;
nit: let's add a comment that bits 25-31 (zero-indexed) are currently
unused (just to make it obvious that this is intentional).
https://codereview.chromium.org/409613002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
