On Saturday, July 19, 2014 7:55:13 AM UTC-4, Jakob Kummerow wrote: > > A few comments: > - for your "git cl presubmit" issue, try executing "make dependencies". It > should pull in the "buildtools" directory, which contains the "checkdeps" > python module (among other things). >
That completely fixed my issue. Doh. > - filing a bug for a V8 CL is fine if you want, but not required. It can > make a lot of sense when you have a series of related CLs, but for a single > fix it just adds bureaucratic overhead, which you are free to skip. > Ok, thanks. I'm doing some simple commits before pushing a big bunch of PowerPC changes - trying to get a solid handle on the process. > - when your CL does belong to a bug, the proper way to reference it is the > BUG= line, e.g. BUG=v8:3449. You'll even get auto-linking :-) > Thanks for that too Appreciate the review -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to v8-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
