Reviewers: dcarney, jochen,
Message:
Please take a look.
Description:
Add bailout checks to Message::Get{Start,End}Column()
Also add an initial ON_BAILOUT() check to these two 'bailout enabled'
accessors.
(The need for these was encountered via http://crbug.com/393273)
R=
BUG=
Please review this at https://codereview.chromium.org/402173003/
SVN Base: git://github.com/v8/v8.git@bleeding_edge
Affected files (+2, -0 lines):
M src/api.cc
Index: src/api.cc
diff --git a/src/api.cc b/src/api.cc
index
fb367de4914ca5321613f17cc3319dfaef1d0fb1..ddc57f26d1b12c39e4ea0d0f139d39f94d4c183a
100644
--- a/src/api.cc
+++ b/src/api.cc
@@ -2068,6 +2068,7 @@ int Message::GetEndPosition() const {
int Message::GetStartColumn() const {
i::Isolate* isolate = Utils::OpenHandle(this)->GetIsolate();
+ ON_BAILOUT(isolate, "v8::Message::GetStartColumn()", return
kNoColumnInfo);
ENTER_V8(isolate);
i::HandleScope scope(isolate);
i::Handle<i::JSObject> data_obj = Utils::OpenHandle(this);
@@ -2082,6 +2083,7 @@ int Message::GetStartColumn() const {
int Message::GetEndColumn() const {
i::Isolate* isolate = Utils::OpenHandle(this)->GetIsolate();
+ ON_BAILOUT(isolate, "v8::Message::GetEndColumn()", return kNoColumnInfo);
ENTER_V8(isolate);
i::HandleScope scope(isolate);
i::Handle<i::JSObject> data_obj = Utils::OpenHandle(this);
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
