https://codereview.chromium.org/409543004/diff/1/src/types.cc
File src/types.cc (right):
https://codereview.chromium.org/409543004/diff/1/src/types.cc#newcode915
src/types.cc:915: os << "Range([" << this->AsRange()->Min()
Let's print this as
Range(0.5..1.7 : bound)
to avoid too many parentheses.
https://codereview.chromium.org/409543004/diff/1/test/cctest/test-types.cc
File test/cctest/test-types.cc (right):
https://codereview.chromium.org/409543004/diff/1/test/cctest/test-types.cc#newcode164
test/cctest/test-types.cc:164: for (int i = 0; i < 40; ++i) {
I suppose 10 to 20 is enough here, esp given that the test is O(N^4)
below. Also, maybe make half the random numbers proper integers, since
that will likely be the common case in practice.
https://codereview.chromium.org/409543004/diff/1/test/cctest/test-types.cc#newcode598
test/cctest/test-types.cc:598: double min = *i <= *j ? *i : *j;
You can use the C++ min & max functions for these.
https://codereview.chromium.org/409543004/diff/1/test/cctest/test-types.cc#newcode616
test/cctest/test-types.cc:616: // Injectivity: Range(min1, max1) =
Range(min2, max2) =>
I think that Functionality should hold as well.
https://codereview.chromium.org/409543004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
