Reviewers: jochen, Jakob,
Message:
PTAL
https://codereview.chromium.org/405373005/diff/1/build/get_landmines.py
File build/get_landmines.py (right):
https://codereview.chromium.org/405373005/diff/1/build/get_landmines.py#newcode15
build/get_landmines.py:15: def main():
Simplified. Can only emit global landmines. Independent of platform,
target, etc.
https://codereview.chromium.org/405373005/diff/1/build/landmines.py
File build/landmines.py (right):
https://codereview.chromium.org/405373005/diff/1/build/landmines.py#newcode61
build/landmines.py:61: if not os.path.exists(out_dir):
The original script creates the dir here. I wonder why. I'd assume the
dir exists if I want to clobber it.
https://codereview.chromium.org/405373005/diff/1/build/landmines.py#newcode120
build/landmines.py:120: for s in landmine_scripts:
I simplified this compared to the original script and removed
target-specific landmine support.
Description:
Add landmines support.
The scripts are copied from chromium/src/build and simplified.
Requires an svn ignore change as well.
BUG=
Please review this at https://codereview.chromium.org/405373005/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+169, -0 lines):
M .gitignore
A build/get_landmines.py
M build/gyp_v8
A build/landmines.py
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
