Comment #1 on issue 3454 by [email protected]: some intl tests fail with ICU 5.2
http://code.google.com/p/v8/issues/detail?id=3454


intl/date-format/parse-mdyhms.js:37: Error: Failure: expected <M/d/y h:mm:ss a>, found <M/d/y, h:mm:ss a>

The above is due to the fact that a newer version of CLDR and ICU has ',' between date and time. Similarly, in the full/long date format, it has 'at' in English locale.

Anyway, that assertion in line 37 need to be updated to have ','.

intl/date-format/parse-MMMdy.js:45: Error: Failure: expected <undefined>, found <Mon Feb 04 1974 08:00:00 GMT+0100 (CET)>

Apparently, ICU's parser got smarter and/or more tolerant and now can deal with the lack of a comma. The lines 44-45 read:

// Missing , in the pattern.
assertEquals(undefined, dtf.v8Parse('Feb 4 1974'));

Now it should read, instead :

date = dtf.v8Parse('Feb 4 1974')
assertEquals(1974, date.getUTCFullYear());
assertEquals(1, date.getUTCMonth());
assertEquals(4, date.getUTCDate());


The 3rd failure is likely to be due to an ICU's tightening of number parsing :


assertEquals(12323, nf.v8Parse('123,23'));

In English locale, ICU does not seem to parse '123,23' as '12323' any more.

The 4th failed for the same reason:
  assertEquals(123.23, nf.v8Parse('123,23%'));


BTW, why don't parse-decimal and parse-percent have more correct cases (like '12,345.67') while having tests for incorrect cases like '123,23.456'? Also, shouldn't we have tests for non-English cases?




--
You received this message because this project is configured to send all issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to