Revision: 22544
Author: [email protected]
Date: Wed Jul 23 09:00:43 2014 UTC
Log: Rebaseline/update the intl tests with ICU 52
Update the following 4 intl tests after ICU 52 roll.
date-format/parse-MMMdy.js
date-format/parse-mdyhms.js
number-format/parse-decimal.js
number-format/parse-percent.js
BUG=v8:3454
TEST=intl/* tests pass.
LOG=Y
[email protected]
Review URL: https://codereview.chromium.org/410733003
Patch from Jungshik Shin <[email protected]>.
http://code.google.com/p/v8/source/detail?r=22544
Modified:
/branches/bleeding_edge/test/intl/date-format/parse-MMMdy.js
/branches/bleeding_edge/test/intl/date-format/parse-mdyhms.js
/branches/bleeding_edge/test/intl/intl.status
/branches/bleeding_edge/test/intl/number-format/parse-decimal.js
/branches/bleeding_edge/test/intl/number-format/parse-percent.js
=======================================
--- /branches/bleeding_edge/test/intl/date-format/parse-MMMdy.js Fri Oct 11
17:54:31 2013 UTC
+++ /branches/bleeding_edge/test/intl/date-format/parse-MMMdy.js Wed Jul 23
09:00:43 2014 UTC
@@ -41,8 +41,11 @@
assertEquals(1, date.getUTCMonth());
assertEquals(4, date.getUTCDate());
-// Missing , in the pattern.
-assertEquals(undefined, dtf.v8Parse('Feb 4 1974'));
+// Missing , in the input is not a problem any more.
+date = dtf.v8Parse('Feb 4 1974');
+assertEquals(1974, date.getUTCFullYear());
+assertEquals(1, date.getUTCMonth());
+assertEquals(4, date.getUTCDate());
// Extra "th" after 4 in the pattern.
assertEquals(undefined, dtf.v8Parse('Feb 4th, 1974'));
=======================================
--- /branches/bleeding_edge/test/intl/date-format/parse-mdyhms.js Fri Oct
11 17:54:31 2013 UTC
+++ /branches/bleeding_edge/test/intl/date-format/parse-mdyhms.js Wed Jul
23 09:00:43 2014 UTC
@@ -34,7 +34,7 @@
timeZone: 'UTC'});
// Make sure we have pattern we expect (may change in the future).
-assertEquals('M/d/y h:mm:ss a', dtf.resolved.pattern);
+assertEquals('M/d/y, h:mm:ss a', dtf.resolved.pattern);
var date = dtf.v8Parse('2/4/74 12:30:42 pm');
assertEquals(1974, date.getUTCFullYear());
=======================================
--- /branches/bleeding_edge/test/intl/intl.status Tue Jul 22 12:27:59 2014
UTC
+++ /branches/bleeding_edge/test/intl/intl.status Wed Jul 23 09:00:43 2014
UTC
@@ -38,11 +38,5 @@
# BUG(2899): default locale for search fails on mac and on android.
'collator/default-locale': [['system == macos or arch == android_arm or
arch == android_ia32', FAIL]],
-
- # BUG(v8:3454).
- 'date-format/parse-MMMdy': [FAIL],
- 'date-format/parse-mdyhms': [FAIL],
- 'number-format/parse-decimal': [FAIL],
- 'number-format/parse-percent': [FAIL],
}], # ALWAYS
]
=======================================
--- /branches/bleeding_edge/test/intl/number-format/parse-decimal.js Wed
Jul 10 10:49:04 2013 UTC
+++ /branches/bleeding_edge/test/intl/number-format/parse-decimal.js Wed
Jul 23 09:00:43 2014 UTC
@@ -30,7 +30,9 @@
assertEquals(123.43, nf.v8Parse('123.43'));
assertEquals(123, nf.v8Parse('123'));
assertEquals(NaN, nf.v8Parse(NaN));
-assertEquals(12323, nf.v8Parse('123,23'));
+
+// a misplaced comma without a decimal point is not tolerated any more.
+assertEquals(undefined, nf.v8Parse('123,23'));
assertEquals(12323.456, nf.v8Parse('123,23.456'));
assertEquals(12323.456, nf.v8Parse('0000000123,23.456'));
assertEquals(-12323.456, nf.v8Parse('-123,23.456'));
=======================================
--- /branches/bleeding_edge/test/intl/number-format/parse-percent.js Wed
Jul 10 10:49:04 2013 UTC
+++ /branches/bleeding_edge/test/intl/number-format/parse-percent.js Wed
Jul 23 09:00:43 2014 UTC
@@ -30,7 +30,9 @@
assertEquals(1.2343, nf.v8Parse('123.43%'));
assertEquals(1.23, nf.v8Parse('123%'));
assertEquals(NaN, nf.v8Parse(NaN));
-assertEquals(123.23, nf.v8Parse('123,23%'));
+
+// a misplaced comma without a decimal point is not tolerated any more.
+assertEquals(undefined, nf.v8Parse('123,23%'));
assertEquals(123.23456, nf.v8Parse('123,23.456%'));
assertEquals(123.23456, nf.v8Parse('0000000123,23.456%'));
assertEquals(-123.23456, nf.v8Parse('-123,23.456%'));
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
