Revision: 22553
Author:   [email protected]
Date:     Wed Jul 23 11:21:19 2014 UTC
Log:      Add bailout checks to Message::Get{Start,End}Column()

Also add an initial ON_BAILOUT() check to these two 'bailout enabled'
accessors.

(The need for these was encountered via http://crbug.com/393273)

[email protected]

Review URL: https://codereview.chromium.org/402173003

Patch from Sigbjorn Finne <[email protected]>.
http://code.google.com/p/v8/source/detail?r=22553

Modified:
 /branches/bleeding_edge/src/api.cc

=======================================
--- /branches/bleeding_edge/src/api.cc  Fri Jul 18 13:28:12 2014 UTC
+++ /branches/bleeding_edge/src/api.cc  Wed Jul 23 11:21:19 2014 UTC
@@ -2068,6 +2068,7 @@

 int Message::GetStartColumn() const {
   i::Isolate* isolate = Utils::OpenHandle(this)->GetIsolate();
+ ON_BAILOUT(isolate, "v8::Message::GetStartColumn()", return kNoColumnInfo);
   ENTER_V8(isolate);
   i::HandleScope scope(isolate);
   i::Handle<i::JSObject> data_obj = Utils::OpenHandle(this);
@@ -2082,6 +2083,7 @@

 int Message::GetEndColumn() const {
   i::Isolate* isolate = Utils::OpenHandle(this)->GetIsolate();
+  ON_BAILOUT(isolate, "v8::Message::GetEndColumn()", return kNoColumnInfo);
   ENTER_V8(isolate);
   i::HandleScope scope(isolate);
   i::Handle<i::JSObject> data_obj = Utils::OpenHandle(this);

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to