Reviewers: Igor Sheludko,
Description:
Version 3.28.43.1 (merged r22638)
Use return value of GetPropertyAttributes to make compiler happy.
[email protected]
BUG=
Please review this at https://codereview.chromium.org/421913006/
SVN Base: https://v8.googlecode.com/svn/trunk
Affected files (+7, -4 lines):
M src/objects.cc
M src/runtime.cc
M src/version.cc
Index: src/objects.cc
diff --git a/src/objects.cc b/src/objects.cc
index
4d08b7999ed27c317b41109f381eafb8d25575c3..01c0831b4ca5001950197e3931dc8a38a5d65889
100644
--- a/src/objects.cc
+++ b/src/objects.cc
@@ -4093,7 +4093,8 @@ void JSObject::AddProperty(Handle<JSObject> object,
Handle<Name> name,
ASSERT(!object->IsJSProxy());
ASSERT(!name->AsArrayIndex(&index));
LookupIterator it(object, name, LookupIterator::CHECK_OWN_REAL);
- GetPropertyAttributes(&it);
+ Maybe<PropertyAttributes> maybe = GetPropertyAttributes(&it);
+ ASSERT(maybe.has_value);
ASSERT(!it.IsFound());
ASSERT(object->map()->is_extensible());
#endif
Index: src/runtime.cc
diff --git a/src/runtime.cc b/src/runtime.cc
index
c195a90271a18b8a3d33f68d5ffbaa48469e6a2d..a3ebfd34bc9029ab2293868fcd8daf9829c8f151
100644
--- a/src/runtime.cc
+++ b/src/runtime.cc
@@ -5251,7 +5251,8 @@ RUNTIME_FUNCTION(Runtime_AddNamedProperty) {
uint32_t index = 0;
ASSERT(!key->ToArrayIndex(&index));
LookupIterator it(object, key, LookupIterator::CHECK_OWN_REAL);
- JSReceiver::GetPropertyAttributes(&it);
+ Maybe<PropertyAttributes> maybe = JSReceiver::GetPropertyAttributes(&it);
+ ASSERT(maybe.has_value);
RUNTIME_ASSERT(!it.IsFound());
#endif
@@ -5282,7 +5283,8 @@ RUNTIME_FUNCTION(Runtime_AddPropertyForTemplate) {
if (key->IsName()) {
LookupIterator it(object, Handle<Name>::cast(key),
LookupIterator::CHECK_OWN_REAL);
- JSReceiver::GetPropertyAttributes(&it);
+ Maybe<PropertyAttributes> maybe =
JSReceiver::GetPropertyAttributes(&it);
+ ASSERT(maybe.has_value);
duplicate = it.IsFound();
} else {
uint32_t index = 0;
Index: src/version.cc
diff --git a/src/version.cc b/src/version.cc
index
13bfdc3c581bfc8b75acfd42f85ec75e3d9de255..1b3f8bab815e6b5fd82b39c1d847f63207c2ceb0
100644
--- a/src/version.cc
+++ b/src/version.cc
@@ -35,7 +35,7 @@
#define MAJOR_VERSION 3
#define MINOR_VERSION 28
#define BUILD_NUMBER 43
-#define PATCH_LEVEL 0
+#define PATCH_LEVEL 1
// Use 1 for candidates and 0 otherwise.
// (Boolean macro values are not supported by all preprocessors.)
#define IS_CANDIDATE_VERSION 0
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
