Addressed comments. Ported to other architectures. Adapted two more test
cases.
PTAL.
Rodolph, could you check if the change to the ARM64 is OK?
https://codereview.chromium.org/410153002/diff/1/src/factory.cc
File src/factory.cc (right):
https://codereview.chromium.org/410153002/diff/1/src/factory.cc#newcode1376
src/factory.cc:1376: !isolate()->bootstrapper()->IsActive() &&
On 2014/07/28 09:56:10, titzer wrote:
Comment me, TODO me?
Done.
https://codereview.chromium.org/410153002/diff/1/test/cctest/test-heap.cc
File test/cctest/test-heap.cc (right):
https://codereview.chromium.org/410153002/diff/1/test/cctest/test-heap.cc#newcode4039
test/cctest/test-heap.cc:4039: if (i::FLAG_always_opt) return;
On 2014/07/28 09:56:10, titzer wrote:
Can we get a TODO in here? It needs some thought on how to make it
work with
more optimized functions, but the coverage is probably worth it.
Done.
https://codereview.chromium.org/410153002/diff/1/test/cctest/test-parsing.cc
File test/cctest/test-parsing.cc (right):
https://codereview.chromium.org/410153002/diff/1/test/cctest/test-parsing.cc#newcode2988
test/cctest/test-parsing.cc:2988: void
MockUseCounterCallback(v8::Isolate* isolate,
On 2014/07/28 09:56:10, titzer wrote:
While you're here, can you rename this? It's not a mock.
Done.
https://codereview.chromium.org/410153002/diff/1/test/mjsunit/debug-compile-event-newfunction.js
File test/mjsunit/debug-compile-event-newfunction.js (right):
https://codereview.chromium.org/410153002/diff/1/test/mjsunit/debug-compile-event-newfunction.js#newcode63
test/mjsunit/debug-compile-event-newfunction.js:63: // Create a function
from its body text. It will lead to an eval.
On 2014/07/28 09:56:10, titzer wrote:
OK, just TODO someone
Done (put it one line below to avoid adapting line numbers).
https://codereview.chromium.org/410153002/diff/40001/src/arm64/lithium-codegen-arm64.cc
File src/arm64/lithium-codegen-arm64.cc (left):
https://codereview.chromium.org/410153002/diff/40001/src/arm64/lithium-codegen-arm64.cc#oldcode5038
src/arm64/lithium-codegen-arm64.cc:5038:
ASM_UNIMPLEMENTED_BREAK("DoDeclareGlobals");
Rodolph, is this OK?
https://codereview.chromium.org/410153002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
