https://codereview.chromium.org/416213004/diff/20001/src/promise.js
File src/promise.js (right):
https://codereview.chromium.org/416213004/diff/20001/src/promise.js#newcode61
src/promise.js:61: var type = status === 0 ? "new" : "update";
On 2014/08/01 07:46:18, aandrey wrote:
remove this and the "type". if you really need it, you can do the
logic in
PromiseEvent.prototype.type:
if (!this._status)
return "new";
else if (this._promiseParent)
return "chain";
else
return "update";
Removed this as we can tell the type of event using status and parent on
backend.
https://codereview.chromium.org/416213004/diff/20001/test/mjsunit/es6/debug-promises-update-parent-event.js
File test/mjsunit/es6/debug-promises-update-parent-event.js (right):
https://codereview.chromium.org/416213004/diff/20001/test/mjsunit/es6/debug-promises-update-parent-event.js#newcode19
test/mjsunit/es6/debug-promises-update-parent-event.js:19: if
(event_data.type() != "chain") return;
On 2014/08/01 07:46:18, aandrey wrote:
just make 1 file to test all promise events
Done.
https://codereview.chromium.org/416213004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
