NOT LGTM.
https://codereview.chromium.org/422363002/diff/20001/src/preparser.h
File src/preparser.h (right):
https://codereview.chromium.org/422363002/diff/20001/src/preparser.h#newcode783
src/preparser.h:783: Type type_ : 2;
This actually blows up memory usage instead of reducing it and has
several portability issues. Please use the BitField class from utils.h,
like the rest of v8.
https://codereview.chromium.org/422363002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
