Reviewers: Sven Panne,

Message:
Committed patchset #1 manually as 22814 (tree was closed).

Description:
Fix tools/generate-runtime-tests.py.

[email protected]

Committed: https://code.google.com/p/v8/source/detail?r=22814

Please review this at https://codereview.chromium.org/436223003/

SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge

Affected files (+5, -70 lines):
  D test/mjsunit/runtime-gen/addnamedproperty.js
  D test/mjsunit/runtime-gen/addpropertyfortemplate.js
  D test/mjsunit/runtime-gen/getoptimizationstatus.js
  D test/mjsunit/runtime-gen/initializevarglobal.js
  D test/mjsunit/runtime-gen/internalizestring.js
  D test/mjsunit/runtime-gen/optimizefunctiononnextcall.js
  D test/mjsunit/runtime-gen/sethiddenproperty.js
  D test/mjsunit/runtime-gen/setinlinebuiltinflag.js
  D test/mjsunit/runtime-gen/setnativeflag.js
  D test/mjsunit/runtime-gen/setproperty.js
  M tools/generate-runtime-tests.py


Index: test/mjsunit/runtime-gen/addnamedproperty.js
diff --git a/test/mjsunit/runtime-gen/addnamedproperty.js b/test/mjsunit/runtime-gen/addnamedproperty.js
deleted file mode 100644
index df4aaed9dbba3720ac5a87794b720be8f4514a6a..0000000000000000000000000000000000000000
--- a/test/mjsunit/runtime-gen/addnamedproperty.js
+++ /dev/null
@@ -1,8 +0,0 @@
-// Copyright 2014 the V8 project authors. All rights reserved.
-// AUTO-GENERATED BY tools/generate-runtime-tests.py, DO NOT MODIFY
-// Flags: --allow-natives-syntax --harmony
-var _object = new Object();
-var arg1 = "bla";
-var _value = new Object();
-var _unchecked_attributes = 1;
-%AddNamedProperty(_object, arg1, _value, _unchecked_attributes);
Index: test/mjsunit/runtime-gen/addpropertyfortemplate.js
diff --git a/test/mjsunit/runtime-gen/addpropertyfortemplate.js b/test/mjsunit/runtime-gen/addpropertyfortemplate.js
deleted file mode 100644
index bb8cf366e819e02d45323e1e806f03ab3406588c..0000000000000000000000000000000000000000
--- a/test/mjsunit/runtime-gen/addpropertyfortemplate.js
+++ /dev/null
@@ -1,8 +0,0 @@
-// Copyright 2014 the V8 project authors. All rights reserved.
-// AUTO-GENERATED BY tools/generate-runtime-tests.py, DO NOT MODIFY
-// Flags: --allow-natives-syntax --harmony
-var _object = new Object();
-var arg1 = 10;
-var _value = new Object();
-var _unchecked_attributes = 1;
-%AddPropertyForTemplate(_object, arg1, _value, _unchecked_attributes);
Index: test/mjsunit/runtime-gen/getoptimizationstatus.js
diff --git a/test/mjsunit/runtime-gen/getoptimizationstatus.js b/test/mjsunit/runtime-gen/getoptimizationstatus.js
deleted file mode 100644
index c38619651c91dc9a005648866ed00bd589251819..0000000000000000000000000000000000000000
--- a/test/mjsunit/runtime-gen/getoptimizationstatus.js
+++ /dev/null
@@ -1,6 +0,0 @@
-// Copyright 2014 the V8 project authors. All rights reserved.
-// AUTO-GENERATED BY tools/generate-runtime-tests.py, DO NOT MODIFY
-// Flags: --allow-natives-syntax --harmony
-var _function = function() {};
-var _sync = "foo";
-%GetOptimizationStatus(_function, _sync);
Index: test/mjsunit/runtime-gen/initializevarglobal.js
diff --git a/test/mjsunit/runtime-gen/initializevarglobal.js b/test/mjsunit/runtime-gen/initializevarglobal.js
deleted file mode 100644
index ad42fdc9ff0978c60ebb98df2e5eadcc14cab18a..0000000000000000000000000000000000000000
--- a/test/mjsunit/runtime-gen/initializevarglobal.js
+++ /dev/null
@@ -1,7 +0,0 @@
-// Copyright 2014 the V8 project authors. All rights reserved.
-// AUTO-GENERATED BY tools/generate-runtime-tests.py, DO NOT MODIFY
-// Flags: --allow-natives-syntax --harmony
-var _name = "foo";
-var _strict_mode = 1;
-var _value = new Object();
-%InitializeVarGlobal(_name, _strict_mode, _value);
Index: test/mjsunit/runtime-gen/internalizestring.js
diff --git a/test/mjsunit/runtime-gen/internalizestring.js b/test/mjsunit/runtime-gen/internalizestring.js
deleted file mode 100644
index 7729f5611dd61de280c681c46c376f5494ce4a84..0000000000000000000000000000000000000000
--- a/test/mjsunit/runtime-gen/internalizestring.js
+++ /dev/null
@@ -1,5 +0,0 @@
-// Copyright 2014 the V8 project authors. All rights reserved.
-// AUTO-GENERATED BY tools/generate-runtime-tests.py, DO NOT MODIFY
-// Flags: --allow-natives-syntax --harmony
-var _string = "foo";
-%InternalizeString(_string);
Index: test/mjsunit/runtime-gen/optimizefunctiononnextcall.js
diff --git a/test/mjsunit/runtime-gen/optimizefunctiononnextcall.js b/test/mjsunit/runtime-gen/optimizefunctiononnextcall.js
deleted file mode 100644
index 435c4ce6a93de338903497ff8b94cf66e9749866..0000000000000000000000000000000000000000
--- a/test/mjsunit/runtime-gen/optimizefunctiononnextcall.js
+++ /dev/null
@@ -1,6 +0,0 @@
-// Copyright 2014 the V8 project authors. All rights reserved.
-// AUTO-GENERATED BY tools/generate-runtime-tests.py, DO NOT MODIFY
-// Flags: --allow-natives-syntax --harmony
-var _function = function() {};
-var _type = "foo";
-%OptimizeFunctionOnNextCall(_function, _type);
Index: test/mjsunit/runtime-gen/sethiddenproperty.js
diff --git a/test/mjsunit/runtime-gen/sethiddenproperty.js b/test/mjsunit/runtime-gen/sethiddenproperty.js
deleted file mode 100644
index 305046a0c8d89f57868e3e01fb0966a0bb2245a2..0000000000000000000000000000000000000000
--- a/test/mjsunit/runtime-gen/sethiddenproperty.js
+++ /dev/null
@@ -1,7 +0,0 @@
-// Copyright 2014 the V8 project authors. All rights reserved.
-// AUTO-GENERATED BY tools/generate-runtime-tests.py, DO NOT MODIFY
-// Flags: --allow-natives-syntax --harmony
-var _object = new Object();
-var _key = "foo";
-var _value = new Object();
-%SetHiddenProperty(_object, _key, _value);
Index: test/mjsunit/runtime-gen/setinlinebuiltinflag.js
diff --git a/test/mjsunit/runtime-gen/setinlinebuiltinflag.js b/test/mjsunit/runtime-gen/setinlinebuiltinflag.js
deleted file mode 100644
index bbcaf9638e1b62886edcbb4a93efb2a290960674..0000000000000000000000000000000000000000
--- a/test/mjsunit/runtime-gen/setinlinebuiltinflag.js
+++ /dev/null
@@ -1,5 +0,0 @@
-// Copyright 2014 the V8 project authors. All rights reserved.
-// AUTO-GENERATED BY tools/generate-runtime-tests.py, DO NOT MODIFY
-// Flags: --allow-natives-syntax --harmony
-var _object = new Object();
-%SetInlineBuiltinFlag(_object);
Index: test/mjsunit/runtime-gen/setnativeflag.js
diff --git a/test/mjsunit/runtime-gen/setnativeflag.js b/test/mjsunit/runtime-gen/setnativeflag.js
deleted file mode 100644
index 60775ac971c5924a3ceb282310fdb5230a761271..0000000000000000000000000000000000000000
--- a/test/mjsunit/runtime-gen/setnativeflag.js
+++ /dev/null
@@ -1,5 +0,0 @@
-// Copyright 2014 the V8 project authors. All rights reserved.
-// AUTO-GENERATED BY tools/generate-runtime-tests.py, DO NOT MODIFY
-// Flags: --allow-natives-syntax --harmony
-var _object = new Object();
-%SetNativeFlag(_object);
Index: test/mjsunit/runtime-gen/setproperty.js
diff --git a/test/mjsunit/runtime-gen/setproperty.js b/test/mjsunit/runtime-gen/setproperty.js
deleted file mode 100644
index 396b0e7039b0bdafadcf24643bc1260c759d0db6..0000000000000000000000000000000000000000
--- a/test/mjsunit/runtime-gen/setproperty.js
+++ /dev/null
@@ -1,8 +0,0 @@
-// Copyright 2014 the V8 project authors. All rights reserved.
-// AUTO-GENERATED BY tools/generate-runtime-tests.py, DO NOT MODIFY
-// Flags: --allow-natives-syntax --harmony
-var _object = new Object();
-var _key = new Object();
-var _value = new Object();
-var _strict_mode_arg = 1;
-%SetProperty(_object, _key, _value, _strict_mode_arg);
Index: tools/generate-runtime-tests.py
diff --git a/tools/generate-runtime-tests.py b/tools/generate-runtime-tests.py index 58175394a3d6ce2e1c6bc6ea0fbc9ae138c538bf..87e9d7ca3b0ab5bb9171f68e0d54d71a5a505f94 100755
--- a/tools/generate-runtime-tests.py
+++ b/tools/generate-runtime-tests.py
@@ -20,7 +20,7 @@ import time
 FILENAME = "src/runtime.cc"
 HEADERFILENAME = "src/runtime.h"
 FUNCTION = re.compile("^RUNTIME_FUNCTION\(Runtime_(\w+)")
-ARGSLENGTH = re.compile(".*ASSERT\(.*args\.length\(\) == (\d+)\);")
+ARGSLENGTH = re.compile(".*DCHECK\(.*args\.length\(\) == (\d+)\);")
 FUNCTIONEND = "}\n"
 MACRO = re.compile(r"^#define ([^ ]+)\(([^)]*)\) *([^\\]*)\\?\n$")
 FIRST_WORD = re.compile("^\s*(.*?)[\s({\[]")
@@ -48,9 +48,9 @@ EXPAND_MACROS = [
# remove or change runtime functions, but make sure we don't lose our ability
 # to parse them!
 EXPECTED_FUNCTION_COUNT = 425
-EXPECTED_FUZZABLE_COUNT = 338
-EXPECTED_CCTEST_COUNT = 9
-EXPECTED_UNKNOWN_COUNT = 4
+EXPECTED_FUZZABLE_COUNT = 328
+EXPECTED_CCTEST_COUNT = 7
+EXPECTED_UNKNOWN_COUNT = 16
 EXPECTED_BUILTINS_COUNT = 816


@@ -58,7 +58,7 @@ EXPECTED_BUILTINS_COUNT = 816
 BLACKLISTED = [
   "Abort",  # Kills the process.
   "AbortJS",  # Kills the process.
-  "CompileForOnStackReplacement",  # Riddled with ASSERTs.
+  "CompileForOnStackReplacement",  # Riddled with DCHECK.
   "IS_VAR",  # Not implemented in the runtime.
   "ListNatives",  # Not available in Release mode.
   "SetAllocationTimeout",  # Too slow for fuzzing.


--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to