Looking good.
https://codereview.chromium.org/422543003/diff/1/src/string.js
File src/string.js (right):
https://codereview.chromium.org/422543003/diff/1/src/string.js#newcode842
src/string.js:842: CHECK_OBJECT_COERCIBLE(this,
"String.prototype.link");
Now that all of this is specified in ES6, do you mind adding the
references to the sections in the ES6 draft (including draft date)?
https://codereview.chromium.org/422543003/diff/1/test/mjsunit/string-html.js
File test/mjsunit/string-html.js (right):
https://codereview.chromium.org/422543003/diff/1/test/mjsunit/string-html.js#newcode4
test/mjsunit/string-html.js:4:
Since this is not specified until es6, could you move this to
test/mjsunit/es6/?
https://codereview.chromium.org/422543003/diff/1/test/mjsunit/string-html.js#newcode66
test/mjsunit/string-html.js:66:
assertEquals(String.prototype.fontcolor.call(0x2A, 0x2A), '<font
color="42">42</font>');
please honor the 80-char limit.
https://codereview.chromium.org/422543003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
