On 2014/08/05 14:58:31, Yang wrote:
On 2014/08/05 13:20:14, Yang wrote:
> On 2014/08/05 13:17:04, Slava Chigrin wrote:
> >
>
https://codereview.chromium.org/441983002/diff/40001/tools/external-reference-check.py
> > File tools/external-reference-check.py (right):
> >
> >
>
https://codereview.chromium.org/441983002/diff/40001/tools/external-reference-check.py#newcode17
> > tools/external-reference-check.py:17: EXPECTED_EXTERNAL_REFERENCES =
100
> > Seems, it is not used. Am I wrong?
>
> AHHH. You are right. I planned to use that, but then forgot about it.
I'll
> remove it, since it doesn't seem to make sense now.
Updated.
- removed EXPECTED_EXTERNAL_REFERENCES
- reordered so that the code is added in ascending order
- automatically increment the ID when adding entries to the UNCLASSIFIED
type.
Since I added one comment before, LGTM .
By the way, I am very thankful for auto-incrementing IDs. :)
https://codereview.chromium.org/441983002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
