Reviewers: Kasper Lund, Description: Go back to doubling the size when growing new space.
Our memory tests show little improvement by only growing by 50%. Please review this at http://codereview.chromium.org/174133 SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M src/spaces.cc M src/v8.cc Index: src/v8.cc =================================================================== --- src/v8.cc (revision 2723) +++ src/v8.cc (working copy) @@ -156,6 +156,7 @@ return (hi << 16) + (lo & 0xFFFF); } + void V8::IdleNotification(bool is_high_priority) { if (!FLAG_use_idle_notification) return; // Ignore high priority instances of V8. Index: src/spaces.cc =================================================================== --- src/spaces.cc (revision 2723) +++ src/spaces.cc (working copy) @@ -1079,9 +1079,9 @@ bool SemiSpace::Grow() { - // Commit 50% extra space but only up to maximum capacity. + // Double the semispace size but only up to maximum capacity. int maximum_extra = maximum_capacity_ - capacity_; - int extra = Min(RoundUp(capacity_ / 2, OS::AllocateAlignment()), + int extra = Min(RoundUp(capacity_, OS::AllocateAlignment()), maximum_extra); if (!MemoryAllocator::CommitBlock(high(), extra, executable())) { return false; --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
