https://codereview.chromium.org/442253002/diff/1/src/compiler/instruction-selector.cc
File src/compiler/instruction-selector.cc (right):
https://codereview.chromium.org/442253002/diff/1/src/compiler/instruction-selector.cc#newcode1003
src/compiler/instruction-selector.cc:1003: descriptor->size(),
&inputs.front(), 0, NULL);
On 2014/08/06 09:41:00, Benedikt Meurer wrote:
Nit: use inputs.size() instead of descriptor->size(). And maybe add a
check that
they're equal.
Done.
https://codereview.chromium.org/442253002/diff/1/src/compiler/instruction.h
File src/compiler/instruction.h (right):
https://codereview.chromium.org/442253002/diff/1/src/compiler/instruction.h#newcode731
src/compiler/instruction.h:731: typedef
std::vector<FrameStateDescriptor*,
On 2014/08/06 09:41:00, Benedikt Meurer wrote:
Why store pointers? FrameStateDescriptor is small, copying is cheap,
so using
pointers here just wastes memory. Or am I missing something?
Yeah, at the moment it is four ints. However, with inlining we will add
a pointer to the parent FrameStateDescriptor, so pointers will make the
representation more consistent. If you feel strongly about this, I am
fine with changing back to storing values.
https://codereview.chromium.org/442253002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
