Reviewers: Yang,
Message:
PTAL
Description:
Use EXPECT_DOUBLE_EQ for floating point comparisons.
Please review this at https://codereview.chromium.org/444933002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+3, -3 lines):
M test/base-unittests/platform/time-unittest.cc
Index: test/base-unittests/platform/time-unittest.cc
diff --git a/test/base-unittests/platform/time-unittest.cc
b/test/base-unittests/platform/time-unittest.cc
index
0eb6795f6613a85c8136518df7ad2b95166b5c9a..409323a8d6000f884fec36dadc9835064f2e4e79
100644
--- a/test/base-unittests/platform/time-unittest.cc
+++ b/test/base-unittests/platform/time-unittest.cc
@@ -31,10 +31,10 @@ TEST(TimeDelta, FromAndIn) {
EXPECT_EQ(static_cast<int>(13), TimeDelta::FromHours(13).InHours());
EXPECT_EQ(static_cast<int>(13), TimeDelta::FromMinutes(13).InMinutes());
EXPECT_EQ(static_cast<int64_t>(13),
TimeDelta::FromSeconds(13).InSeconds());
- EXPECT_EQ(13.0, TimeDelta::FromSeconds(13).InSecondsF());
+ EXPECT_DOUBLE_EQ(13.0, TimeDelta::FromSeconds(13).InSecondsF());
EXPECT_EQ(static_cast<int64_t>(13),
TimeDelta::FromMilliseconds(13).InMilliseconds());
- EXPECT_EQ(13.0, TimeDelta::FromMilliseconds(13).InMillisecondsF());
+ EXPECT_DOUBLE_EQ(13.0,
TimeDelta::FromMilliseconds(13).InMillisecondsF());
EXPECT_EQ(static_cast<int64_t>(13),
TimeDelta::FromMicroseconds(13).InMicroseconds());
}
@@ -54,7 +54,7 @@ TEST(TimeDelta, MachTimespec) {
TEST(Time, JsTime) {
Time t = Time::FromJsTime(700000.3);
- EXPECT_EQ(700000.3, t.ToJsTime());
+ EXPECT_DOUBLE_EQ(700000.3, t.ToJsTime());
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
