Revision: 22917
Author: [email protected]
Date: Wed Aug 6 10:23:04 2014 UTC
Log: Use EXPECT_DOUBLE_EQ for floating point comparisons.
[email protected]
Review URL: https://codereview.chromium.org/444933002
http://code.google.com/p/v8/source/detail?r=22917
Modified:
/branches/bleeding_edge/test/base-unittests/platform/time-unittest.cc
=======================================
--- /branches/bleeding_edge/test/base-unittests/platform/time-unittest.cc
Wed Aug 6 09:50:17 2014 UTC
+++ /branches/bleeding_edge/test/base-unittests/platform/time-unittest.cc
Wed Aug 6 10:23:04 2014 UTC
@@ -31,10 +31,10 @@
EXPECT_EQ(static_cast<int>(13), TimeDelta::FromHours(13).InHours());
EXPECT_EQ(static_cast<int>(13), TimeDelta::FromMinutes(13).InMinutes());
EXPECT_EQ(static_cast<int64_t>(13),
TimeDelta::FromSeconds(13).InSeconds());
- EXPECT_EQ(13.0, TimeDelta::FromSeconds(13).InSecondsF());
+ EXPECT_DOUBLE_EQ(13.0, TimeDelta::FromSeconds(13).InSecondsF());
EXPECT_EQ(static_cast<int64_t>(13),
TimeDelta::FromMilliseconds(13).InMilliseconds());
- EXPECT_EQ(13.0, TimeDelta::FromMilliseconds(13).InMillisecondsF());
+ EXPECT_DOUBLE_EQ(13.0,
TimeDelta::FromMilliseconds(13).InMillisecondsF());
EXPECT_EQ(static_cast<int64_t>(13),
TimeDelta::FromMicroseconds(13).InMicroseconds());
}
@@ -54,7 +54,7 @@
TEST(Time, JsTime) {
Time t = Time::FromJsTime(700000.3);
- EXPECT_EQ(700000.3, t.ToJsTime());
+ EXPECT_DOUBLE_EQ(700000.3, t.ToJsTime());
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
