LGTM
http://codereview.chromium.org/173115/diff/1/7 File src/objects-inl.h (right): http://codereview.chromium.org/173115/diff/1/7#newcode940 Line 940: int map_page_index = static_cast<int>( How about putting all on the next line - I think that should fit? int map_page_index = static_cast<int>((value_ & kMapPageIndexMask) >> kMapPageIndexShift); http://codereview.chromium.org/173115/diff/1/6 File src/x64/codegen-x64.h (right): http://codereview.chromium.org/173115/diff/1/6#newcode35 Line 35: const int32_t kSmiTagMask32 = 0x00000001; Maybe we can have kSmiTagMask always be a 32-bit type instead of adding another constant? http://codereview.chromium.org/173115 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
