Revision: 22943
Author: [email protected]
Date: Wed Aug 6 16:56:52 2014 UTC
Log: Get rid of the "spare buffer" cache.
BUG=
[email protected]
Review URL: https://codereview.chromium.org/446923002
http://code.google.com/p/v8/source/detail?r=22943
Modified:
/branches/bleeding_edge/src/arm/assembler-arm.cc
/branches/bleeding_edge/src/arm64/assembler-arm64.cc
/branches/bleeding_edge/src/assembler.cc
/branches/bleeding_edge/src/ia32/assembler-ia32.cc
/branches/bleeding_edge/src/isolate.cc
/branches/bleeding_edge/src/isolate.h
/branches/bleeding_edge/src/x64/assembler-x64.cc
/branches/bleeding_edge/src/x87/assembler-x87.cc
=======================================
--- /branches/bleeding_edge/src/arm/assembler-arm.cc Mon Aug 4 11:34:54
2014 UTC
+++ /branches/bleeding_edge/src/arm/assembler-arm.cc Wed Aug 6 16:56:52
2014 UTC
@@ -3202,8 +3202,8 @@
// Compute new buffer size.
CodeDesc desc; // the new buffer
- if (buffer_size_ < 4*KB) {
- desc.buffer_size = 4*KB;
+ if (buffer_size_ == 0) {
+ desc.buffer_size = kMinimalBufferSize;
} else if (buffer_size_ < 1*MB) {
desc.buffer_size = 2*buffer_size_;
} else {
=======================================
--- /branches/bleeding_edge/src/arm64/assembler-arm64.cc Mon Aug 4
12:46:43 2014 UTC
+++ /branches/bleeding_edge/src/arm64/assembler-arm64.cc Wed Aug 6
16:56:52 2014 UTC
@@ -2771,8 +2771,8 @@
// Compute new buffer size.
CodeDesc desc; // the new buffer
- if (buffer_size_ < 4 * KB) {
- desc.buffer_size = 4 * KB;
+ if (buffer_size_ == 0) {
+ desc.buffer_size = kMinimalBufferSize;
} else if (buffer_size_ < 1 * MB) {
desc.buffer_size = 2 * buffer_size_;
} else {
=======================================
--- /branches/bleeding_edge/src/assembler.cc Wed Aug 6 07:20:14 2014 UTC
+++ /branches/bleeding_edge/src/assembler.cc Wed Aug 6 16:56:52 2014 UTC
@@ -136,14 +136,7 @@
}
if (buffer == NULL) {
// Do our own buffer management.
- if (buffer_size <= kMinimalBufferSize) {
- buffer_size = kMinimalBufferSize;
- if (isolate->assembler_spare_buffer() != NULL) {
- buffer = isolate->assembler_spare_buffer();
- isolate->set_assembler_spare_buffer(NULL);
- }
- }
- if (buffer == NULL) buffer = NewArray<byte>(buffer_size);
+ buffer = NewArray<byte>(buffer_size);
own_buffer_ = true;
} else {
// Use externally provided buffer instead.
@@ -158,15 +151,7 @@
AssemblerBase::~AssemblerBase() {
- if (own_buffer_) {
- if (isolate() != NULL &&
- isolate()->assembler_spare_buffer() == NULL &&
- buffer_size_ == kMinimalBufferSize) {
- isolate()->set_assembler_spare_buffer(buffer_);
- } else {
- DeleteArray(buffer_);
- }
- }
+ if (own_buffer_) DeleteArray(buffer_);
}
=======================================
--- /branches/bleeding_edge/src/ia32/assembler-ia32.cc Mon Aug 4 11:34:54
2014 UTC
+++ /branches/bleeding_edge/src/ia32/assembler-ia32.cc Wed Aug 6 16:56:52
2014 UTC
@@ -2497,8 +2497,8 @@
// Compute new buffer size.
CodeDesc desc; // the new buffer
- if (buffer_size_ < 4*KB) {
- desc.buffer_size = 4*KB;
+ if (buffer_size_ == 0) {
+ desc.buffer_size = kMinimalBufferSize;
} else {
desc.buffer_size = 2*buffer_size_;
}
@@ -2528,12 +2528,7 @@
desc.reloc_size);
// Switch buffers.
- if (isolate()->assembler_spare_buffer() == NULL &&
- buffer_size_ == kMinimalBufferSize) {
- isolate()->set_assembler_spare_buffer(buffer_);
- } else {
- DeleteArray(buffer_);
- }
+ DeleteArray(buffer_);
buffer_ = desc.buffer;
buffer_size_ = desc.buffer_size;
pc_ += pc_delta;
=======================================
--- /branches/bleeding_edge/src/isolate.cc Wed Aug 6 13:18:36 2014 UTC
+++ /branches/bleeding_edge/src/isolate.cc Wed Aug 6 16:56:52 2014 UTC
@@ -1645,9 +1645,6 @@
delete entry_stack_;
entry_stack_ = NULL;
- delete[] assembler_spare_buffer_;
- assembler_spare_buffer_ = NULL;
-
delete unicode_cache_;
unicode_cache_ = NULL;
=======================================
--- /branches/bleeding_edge/src/isolate.h Tue Aug 5 08:18:22 2014 UTC
+++ /branches/bleeding_edge/src/isolate.h Wed Aug 6 16:56:52 2014 UTC
@@ -340,8 +340,6 @@
V(int, serialize_partial_snapshot_cache_capacity,
0) \
V(Object**, serialize_partial_snapshot_cache,
NULL) \
/* Assembler state.
*/ \
- /* A previously allocated buffer of kMinimalBufferSize bytes, or NULL.
*/ \
- V(byte*, assembler_spare_buffer,
NULL) \
V(FatalErrorCallback, exception_behavior,
NULL) \
V(LogEventCallback, event_logger,
NULL) \
V(AllowCodeGenerationFromStringsCallback, allow_code_gen_callback,
NULL) \
=======================================
--- /branches/bleeding_edge/src/x64/assembler-x64.cc Mon Aug 4 11:34:54
2014 UTC
+++ /branches/bleeding_edge/src/x64/assembler-x64.cc Wed Aug 6 16:56:52
2014 UTC
@@ -331,8 +331,8 @@
// Compute new buffer size.
CodeDesc desc; // the new buffer
- if (buffer_size_ < 4*KB) {
- desc.buffer_size = 4*KB;
+ if (buffer_size_ == 0) {
+ desc.buffer_size = kMinimalBufferSize;
} else {
desc.buffer_size = 2*buffer_size_;
}
@@ -364,13 +364,7 @@
desc.reloc_size);
// Switch buffers.
- if (isolate() != NULL &&
- isolate()->assembler_spare_buffer() == NULL &&
- buffer_size_ == kMinimalBufferSize) {
- isolate()->set_assembler_spare_buffer(buffer_);
- } else {
- DeleteArray(buffer_);
- }
+ DeleteArray(buffer_);
buffer_ = desc.buffer;
buffer_size_ = desc.buffer_size;
pc_ += pc_delta;
=======================================
--- /branches/bleeding_edge/src/x87/assembler-x87.cc Mon Aug 4 11:34:54
2014 UTC
+++ /branches/bleeding_edge/src/x87/assembler-x87.cc Wed Aug 6 16:56:52
2014 UTC
@@ -1910,13 +1910,7 @@
MemMove(rc_delta + reloc_info_writer.pos(), reloc_info_writer.pos(),
desc.reloc_size);
- // Switch buffers.
- if (isolate()->assembler_spare_buffer() == NULL &&
- buffer_size_ == kMinimalBufferSize) {
- isolate()->set_assembler_spare_buffer(buffer_);
- } else {
- DeleteArray(buffer_);
- }
+ DeleteArray(buffer_);
buffer_ = desc.buffer;
buffer_size_ = desc.buffer_size;
pc_ += pc_delta;
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
