Reviewers: Toon Verwaest, danno, paul.l..., gergely.kis.imgtec,
balazs.kilvady, dusmil.imgtec,
Message:
PTAL.
Description:
MIPS: We should never allocate a 0-sized buffer, so never grow from 0.
Port r22947 (e72b5aed) and r22944 (d1d8f44c)
BUG=
Please review this at https://codereview.chromium.org/446923003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+2, -6 lines):
M src/mips/assembler-mips.cc
M src/mips64/assembler-mips64.cc
Index: src/mips/assembler-mips.cc
diff --git a/src/mips/assembler-mips.cc b/src/mips/assembler-mips.cc
index
e959b41adfee2eb2adc1e50ed1ce5cb7367a9594..936a73b5f9e2930682e590a0de934606b523497a
100644
--- a/src/mips/assembler-mips.cc
+++ b/src/mips/assembler-mips.cc
@@ -1974,9 +1974,7 @@ void Assembler::GrowBuffer() {
// Compute new buffer size.
CodeDesc desc; // The new buffer.
- if (buffer_size_ < 4*KB) {
- desc.buffer_size = 4*KB;
- } else if (buffer_size_ < 1*MB) {
+ if (buffer_size_ < 1 * MB) {
desc.buffer_size = 2*buffer_size_;
} else {
desc.buffer_size = buffer_size_ + 1*MB;
Index: src/mips64/assembler-mips64.cc
diff --git a/src/mips64/assembler-mips64.cc b/src/mips64/assembler-mips64.cc
index
bc61695d314fb0ea03ba86c48eb5348ac820eedc..36e9c2d1057ef53785f9ece73f0f9c7aed06d4c0
100644
--- a/src/mips64/assembler-mips64.cc
+++ b/src/mips64/assembler-mips64.cc
@@ -2631,9 +2631,7 @@ void Assembler::GrowBuffer() {
// Compute new buffer size.
CodeDesc desc; // The new buffer.
- if (buffer_size_ < 4*KB) {
- desc.buffer_size = 4*KB;
- } else if (buffer_size_ < 1*MB) {
+ if (buffer_size_ < 1 * MB) {
desc.buffer_size = 2*buffer_size_;
} else {
desc.buffer_size = buffer_size_ + 1*MB;
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
