LGTM.
http://codereview.chromium.org/174141/diff/1002/12 File src/global-handles.cc (right): http://codereview.chromium.org/174141/diff/1002/12#newcode279 Line 279: int time_stamp = 0; You could expose Heap::mc_count() instead of introducing a new variable for this. http://codereview.chromium.org/174141/diff/1002/12#newcode292 Line 292: // Weak callback triggered another GC, the only safe thing Could you describe in the comment why it is unsafe to delete the DESTROYED nodes: When we return to the other instance of PostGarbageCollectionProcessing the p in the code below could have been deleted if it was Disposed in the callback. http://codereview.chromium.org/174141/diff/1002/12#newcode294 Line 294: // or abort it, let's abort as it's simpler :) Terminate comment with '.' and remove the smiley. :) http://codereview.chromium.org/174141/diff/1002/11 File src/heap.cc (right): http://codereview.chromium.org/174141/diff/1002/11#newcode490 Line 490: if (!old_value) allow_allocation(false); Just call allow_allocation with old_value? http://codereview.chromium.org/174141 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
