CreateDataPropertyOrThrow is new in the ES6 spec, which explains why it hasn't
occurred in V8 so far. (Likewise, DONT_DELETE predates ES5, which chose to
rename it to (not) configurable, along with renames for the other property
attributes.)

On the other hand, V8 internally distinguished named properties from indexed
properties (a.k.a. elements). We also have to fit in V8 API functionality like interceptors, which sometimes is at odds with how the spec is factored. We hence need different sets of methods internally, with somewhat different invariants.

It would definitely make sense to clean some of this up and get it more in sync with the new spec. We are slowly doing some such clean-ups, but it's not trivial at all. It needs to be designed carefully, and definitely is outside the scope
of this CL.

For the time being, CreateDataProperty should translate to AddProperty/Element. Assignment definitely is incorrect (which might well be wrong in other places
currently -- please feel free to submit patches :) ).

https://codereview.chromium.org/364853009/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to