https://codereview.chromium.org/424973004/diff/40001/src/cpu-profiler.cc
File src/cpu-profiler.cc (right):
https://codereview.chromium.org/424973004/diff/40001/src/cpu-profiler.cc#newcode260
src/cpu-profiler.cc:260: ASSERT(Script::cast(shared->script()));
On 2014/08/11 12:18:15, alph wrote:
nit: DCHECK here and everywhere else.
Also cast does SLOW_DCHECK internally.
Anyway if you still want to do the check here, it's better to use:
DCHECK(shared->script()->IsScript());
DCHECK is undefined. Do you suggest to use the CHECK macro?
https://codereview.chromium.org/424973004/diff/40001/src/cpu-profiler.cc#newcode265
src/cpu-profiler.cc:265: Handle<Script>
script_handle(Script::cast(shared->script()));
On 2014/08/11 12:18:15, alph wrote:
nit: you can use the 'script' pointer calculated above.
Acknowledged.
https://codereview.chromium.org/424973004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
