This change as is will break Chrome and NodeJS (and other embedders of V8).
The problem is that the web depends on the O.p.toString behavior for host
objects. For example:
assert(Object.prototype.toString.call(document.body) === '[object
HTMLBodyElement]')
The embedder calls the V8 API FunctionTemplate::SetClassName which is then
used.
With this change that class name is now ignored.
Then there is also: v8::Object::ObjectProtoToString which also needs to be
updated:
https://code.google.com/p/chromium/codesearch#chromium/src/v8/src/api.cc&l=3280
https://codereview.chromium.org/461453002/diff/1/src/v8natives.js
File src/v8natives.js (right):
https://codereview.chromium.org/461453002/diff/1/src/v8natives.js#newcode226
src/v8natives.js:226: if(reservedTags.indexOf(builtinTag) === -1){
Can you change this to a switch? We do not want a linear search for all
of these.
https://codereview.chromium.org/461453002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
