Revision: 23075
Author: [email protected]
Date: Tue Aug 12 12:30:22 2014 UTC
Log: Reduce redundant phi nodes after graph building.
[email protected]
Review URL: https://codereview.chromium.org/461003002
http://code.google.com/p/v8/source/detail?r=23075
Modified:
/branches/bleeding_edge/src/compiler/pipeline.cc
/branches/bleeding_edge/test/benchmarks/benchmarks.status
=======================================
--- /branches/bleeding_edge/src/compiler/pipeline.cc Mon Aug 11 13:07:32
2014 UTC
+++ /branches/bleeding_edge/src/compiler/pipeline.cc Tue Aug 12 12:30:22
2014 UTC
@@ -14,6 +14,7 @@
#include "src/compiler/js-context-specialization.h"
#include "src/compiler/js-generic-lowering.h"
#include "src/compiler/js-typed-lowering.h"
+#include "src/compiler/phi-reducer.h"
#include "src/compiler/register-allocator.h"
#include "src/compiler/schedule.h"
#include "src/compiler/scheduler.h"
@@ -144,6 +145,17 @@
graph_builder.CreateGraph();
context_node = graph_builder.GetFunctionContext();
}
+ {
+ PhaseStats phi_reducer_stats(info(), PhaseStats::CREATE_GRAPH,
+ "phi reduction");
+ PhiReducer phi_reducer;
+ GraphReducer graph_reducer(&graph);
+ graph_reducer.AddReducer(&phi_reducer);
+ graph_reducer.ReduceGraph();
+ // TODO(mstarzinger): Running reducer once ought to be enough for
everyone.
+ graph_reducer.ReduceGraph();
+ graph_reducer.ReduceGraph();
+ }
VerifyAndPrintGraph(&graph, "Initial untyped");
=======================================
--- /branches/bleeding_edge/test/benchmarks/benchmarks.status Fri Aug 8
14:07:50 2014 UTC
+++ /branches/bleeding_edge/test/benchmarks/benchmarks.status Tue Aug 12
12:30:22 2014 UTC
@@ -25,14 +25,11 @@
# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-
[
[ALWAYS, {
- # Too slow in Debug mode. TODO(mstarzinger): Too slow for TF.
- 'octane/mandreel': [PASS, NO_VARIANTS, ['mode == debug', SKIP]],
+ # Too slow in Debug mode.
+ 'octane/mandreel': [PASS, ['mode == debug', SKIP]],
# TODO(mstarzinger,ishell): Timeout with TF in predictable mode.
'octane/richards': [PASS, NO_VARIANTS],
- # TODO(mstarzinger): Out of mem with TF.
- 'octane/zlib': [PASS, NO_VARIANTS],
}], # ALWAYS
]
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
