You can use --expose-builtins-as=... (On phone now so I can't check the exact name) On Aug 15, 2014 7:07 PM, <dslo...@chromium.org> wrote:
> On 2014/08/15 23:02:41, arv wrote: > > https://codereview.chromium.org/475423003/diff/20001/test/ > mjsunit/harmony/toMethod.js > >> File test/mjsunit/harmony/toMethod.js (right): >> > > > https://codereview.chromium.org/475423003/diff/20001/test/ > mjsunit/harmony/toMethod.js#newcode80 > >> test/mjsunit/harmony/toMethod.js:80: assertEquals(o, >> fMeth[%HomeObjectSymbol()]); >> On 2014/08/15 22:56:57, Dmitry Lomov (chromium) wrote: >> > On 2014/08/15 22:28:48, arv wrote: >> > > Maybe define the private symbol in harmony-classes.js. That way there >> is >> > no > >> > need >> > > for the runtime function. >> > >> > I am not sure what the suggestion is. >> > a) we need HomeObjectSymbol outside of harmony-classes.js for codegen >> > b) without runtime function, how would we test this here? >> > > The way we have done this before is that we define the symbol in the js >> file >> > and > >> then we use INSTALL_NATIVE in bootstrapper >> > > See symbolIterator for example. >> > > Oh no, symbolIterator only works because it is user-accessible, and > HomeObjectSymbol is not. > Without the runtime function, there is no way (and there should not be) > for the > test to access it. > > https://codereview.chromium.org/475423003/ > -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to v8-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
