Reviewers: Michael Starzinger,
Message:
Committed patchset #1 manually as 23137 (tree was closed).
Description:
During graph scheduling, traverse the roots in one go.
This makes the scheduler more than 30x faster on zlib.
BUG=
[email protected]
Committed: https://code.google.com/p/v8/source/detail?r=23137
Please review this at https://codereview.chromium.org/474963002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+3, -4 lines):
M src/compiler/scheduler.cc
Index: src/compiler/scheduler.cc
diff --git a/src/compiler/scheduler.cc b/src/compiler/scheduler.cc
index
dc497e70efba71aef6878b04549e9fb5795aaffd..d7eb50d1c51ba4d410d2b04c64779daec359d3c1
100644
--- a/src/compiler/scheduler.cc
+++ b/src/compiler/scheduler.cc
@@ -621,13 +621,12 @@ void Scheduler::ScheduleLate() {
// Schedule: Places nodes in dominator block of all their uses.
ScheduleLateNodeVisitor schedule_late_visitor(this);
- for (NodeVectorIter i = schedule_root_nodes_.begin();
- i != schedule_root_nodes_.end(); ++i) {
- // TODO(mstarzinger): Make the scheduler eat less memory.
+ {
Zone zone(zone_->isolate());
GenericGraphVisit::Visit<ScheduleLateNodeVisitor,
NodeInputIterationTraits<Node> >(
- graph_, &zone, *i, &schedule_late_visitor);
+ graph_, &zone, schedule_root_nodes_.begin(),
schedule_root_nodes_.end(),
+ &schedule_late_visitor);
}
// Add collected nodes for basic blocks to their blocks in the right
order.
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
