On 2014/08/18 10:20:29, titzer wrote:
I like the direction of this.
As with context specialization, this closure specialization should
probably be
configurable. Consider adding a flag to turn it on/off.
https://codereview.chromium.org/474633003/diff/20001/src/compiler/ast-graph-builder.cc
File src/compiler/ast-graph-builder.cc (right):
https://codereview.chromium.org/474633003/diff/20001/src/compiler/ast-graph-builder.cc#newcode1942
src/compiler/ast-graph-builder.cc:1942: Node* field_load =
NewNode(machine.Load(kRepTagged), object,
I think you want kAnyTagged here, that's both a type and a representation.
I addressed the comments. As discussed, context specialization will
specialize
the cases this patch generalizes, except for some field loads. I'd like to
submit an optimization that folds the field loads in a separate patch.
https://codereview.chromium.org/474633003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
