Reviewers: Jakob,
Message:
PTAL
Description:
Add temporary hack compatible with old delete behavior so we can roll into
blink. We'll need to update the broken test.
BUG=
Please review this at https://codereview.chromium.org/483753003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+4, -0 lines):
M src/objects.cc
Index: src/objects.cc
diff --git a/src/objects.cc b/src/objects.cc
index
d407f74c644c619c71c4af592071901bad26b2b5..897cdadbd138d310868dbc3fce8cf9b96f32cb1a
100644
--- a/src/objects.cc
+++ b/src/objects.cc
@@ -5041,6 +5041,10 @@ MaybeHandle<Object>
JSObject::DeleteProperty(Handle<JSObject> object,
? KEEP_INOBJECT_PROPERTIES
: CLEAR_INOBJECT_PROPERTIES;
Handle<JSObject> holder = it.GetHolder<JSObject>();
+ // TODO(verwaest): Remove this temporary compatibility hack.
+ if (!holder.is_identical_to(object)) {
+ return it.isolate()->factory()->true_value();
+ }
NormalizeProperties(holder, mode, 0);
Handle<Object> result =
DeleteNormalizedProperty(holder, name, delete_mode);
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
