LGTM with some last comments.
https://codereview.chromium.org/478163002/diff/80001/test/test262/testcfg.py
File test/test262/testcfg.py (right):
https://codereview.chromium.org/478163002/diff/80001/test/test262/testcfg.py#newcode97
test/test262/testcfg.py:97: raise Error("Cannot load parseTestRecord;
you may need to --download-data for test262")
The only way this can happen is when there was an exception when trying
to import the module, right? So you can move it to the right place. And
please respect the 80 column limit. Don't be afraid of line breaks!
They're really easy in Python:
try:
...
except:
raise Error("Cannot load parseTestRecord; you may need to "
"--download-data for test262")
finally:
...
https://codereview.chromium.org/478163002/diff/80001/test/test262/testcfg.py#newcode101
test/test262/testcfg.py:101: ParseTestRecord =
self.LoadParseTestRecord()
Let's move this into the if-block where it's needed.
https://codereview.chromium.org/478163002/diff/80001/test/test262/testcfg.py#newcode111
test/test262/testcfg.py:111: for f in test_record["includes"]]
nit: please adjust indentation here
https://codereview.chromium.org/478163002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
