Reviewers: Jakob,
Message:
PTAL
Description:
Get rid of last non-storeic use of JSReceiver::Lookup
BUG=
Please review this at https://codereview.chromium.org/487333002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+2, -4 lines):
M src/hydrogen.cc
Index: src/hydrogen.cc
diff --git a/src/hydrogen.cc b/src/hydrogen.cc
index
d5adca6c97b269bbc572b9b06588c03a254f965c..5fbf27c95c2b9561619602bcc9825d735e79f172
100644
--- a/src/hydrogen.cc
+++ b/src/hydrogen.cc
@@ -5292,10 +5292,8 @@ HOptimizedGraphBuilder::GlobalPropertyAccess
return kUseGeneric;
}
Handle<GlobalObject> global(current_info()->global_object());
- global->Lookup(var->name(), lookup);
- if (!lookup->IsNormal() ||
- (access_type == STORE && lookup->IsReadOnly()) ||
- lookup->holder() != *global) {
+ LookupIterator it(global, var->name(), LookupIterator::CHECK_PROPERTY);
+ if (!it.HasProperty() || (access_type == STORE && it.IsReadOnly())) {
return kUseGeneric;
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
