On 2014/08/19 16:04:49, Toon Verwaest wrote:
https://codereview.chromium.org/481043002/diff/1/src/api.cc
File src/api.cc (right):
https://codereview.chromium.org/481043002/diff/1/src/api.cc#newcode4058
src/api.cc:4058: i::LookupIterator it(func, property_name,
On 2014/08/19 16:01:15, aandrey wrote:
> this var is not used, or does it behave like a scope? (then
LookupIteratorScope
> would be a better name)
I just realized, hence https://codereview.chromium.org/485113003/
https://codereview.chromium.org/481043002/diff/1/src/api.cc#newcode4062
src/api.cc:4062: i::JSObject::GetDataProperty(func, property_name);
On 2014/08/19 16:01:15, aandrey wrote:
> this should not result in any side effects, like calling getter
functions
> (that's why GetLazyValue was used). is it still the case?
Yes, that's what GetDataProperty is for.
REGRESSION: window.localStorage doesn't persist its content after this patch
1) open devtools
2) select sources tab
3) reopen devtools
expected: sources tab is selected
actual: elements tab is selected
https://codereview.chromium.org/481043002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
