Revision: 23261
Author: [email protected]
Date: Thu Aug 21 08:19:05 2014 UTC
Log: Remove last LookupOwnRealNamedProperty usage from runtime.cc
BUG=
[email protected]
Review URL: https://codereview.chromium.org/494663002
http://code.google.com/p/v8/source/detail?r=23261
Modified:
/branches/bleeding_edge/src/property.h
/branches/bleeding_edge/src/runtime.cc
=======================================
--- /branches/bleeding_edge/src/property.h Thu Aug 21 08:16:06 2014 UTC
+++ /branches/bleeding_edge/src/property.h Thu Aug 21 08:19:05 2014 UTC
@@ -252,8 +252,7 @@
}
bool IsNormal() const {
- DCHECK(!(details_.type() == NORMAL && !IsFound()));
- return IsDescriptorOrDictionary() && type() == NORMAL;
+ return IsFound() && IsDescriptorOrDictionary() && type() == NORMAL;
}
bool IsConstant() const {
=======================================
--- /branches/bleeding_edge/src/runtime.cc Wed Aug 20 19:21:56 2014 UTC
+++ /branches/bleeding_edge/src/runtime.cc Thu Aug 21 08:19:05 2014 UTC
@@ -5027,15 +5027,12 @@
return isolate->heap()->undefined_value();
}
- LookupResult lookup(isolate);
- js_object->LookupOwnRealNamedProperty(name, &lookup);
+ LookupIterator it(js_object, name, LookupIterator::CHECK_PROPERTY);
// Take special care when attributes are different and there is already
- // a property. For simplicity we normalize the property which enables us
- // to not worry about changing the instance_descriptor and creating a new
- // map.
- if (lookup.IsFound() &&
- (attr != lookup.GetAttributes() || lookup.IsPropertyCallbacks())) {
+ // a property.
+ if (it.IsFound() && it.HasProperty() &&
+ it.property_kind() == LookupIterator::ACCESSOR) {
// Use IgnoreAttributes version since a readonly property may be
// overridden and SetProperty does not allow this.
Handle<Object> result;
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
