lgtm
https://codereview.chromium.org/494343002/diff/1/test/base-unittests/platform/semaphore-unittest.cc
File test/base-unittests/platform/semaphore-unittest.cc (right):
https://codereview.chromium.org/494343002/diff/1/test/base-unittests/platform/semaphore-unittest.cc#newcode123
test/base-unittests/platform/semaphore-unittest.cc:123:
EXPECT_FALSE(semaphore.WaitFor(TimeDelta::FromMicroseconds(1)));
What's the difference to ASSERT_FALSE above?
https://codereview.chromium.org/494343002/diff/1/test/base-unittests/platform/semaphore-unittest.cc#newcode133
test/base-unittests/platform/semaphore-unittest.cc:133:
ASSERT_FALSE(semaphore.WaitFor(TimeDelta::FromMicroseconds(1000)));
Do we really need the last one? What could make that break?
https://codereview.chromium.org/494343002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
