On 2014/08/21 09:15:13, earthdok wrote:
On 2014/08/21 08:13:46, Jakob wrote:
> LGTM, we can give this a shot.
>
> Considering that MSan is only run with simulators, this approach
shouldn't
> introduce false positives due to missing unpoisoning. Have you run it
locally
to
> see if it reports anything?
I've only verified that the reproducer in issue 403409 causes an MSan
report
after this change. I've not done much to check that no false positives
have
been
introduced.
By the way, I think the annotations in msan.h
under !defined(USE_SIMULATOR)
can
be removed, as we don't have any plans to support that mode of usage. I'll
wait
for an OK from eugenis@ and then nuke them.
This sounds like a good idea.
https://codereview.chromium.org/480763003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
