LGTM
http://codereview.chromium.org/179059/diff/1/2 File src/heap.cc (right): http://codereview.chromium.org/179059/diff/1/2#newcode3995 Line 3995: for (int i = 0; i < kCacheSize; i++) { Would memcpy be faster here? http://codereview.chromium.org/179059/diff/1/4 File src/heap.h (right): http://codereview.chromium.org/179059/diff/1/4#newcode1532 Line 1532: static inline Object* Get(Type type, double input) { Please add a (short) comment on this public Get function. http://codereview.chromium.org/179059/diff/1/4#newcode1533 Line 1533: TranscendentalCache* cache = caches_[type]; The description says "Cache the results of slow math operations on machines that don't have hardware fpu instructions to execute them.", however it looks as if the cache is always enabled. Is that intentional? http://codereview.chromium.org/179059 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
