https://codereview.chromium.org/515103002/diff/1/test/cctest/compiler/test-run-inlining.cc
File test/cctest/compiler/test-run-inlining.cc (right):
https://codereview.chromium.org/515103002/diff/1/test/cctest/compiler/test-run-inlining.cc#newcode234
test/cctest/compiler/test-run-inlining.cc:234:
"Object.defineProperty(obj1, \"y\", { value: 42, writable: false });"
It seems "obj1" is never defined. This means that this line will
essentially be a no-op I think. There is a shorter way of writing this
which avoid this problem (also applies above) ...
var x = Object.create({}, { y: { value:42, writable:false } });
https://codereview.chromium.org/515103002/diff/1/test/cctest/compiler/test-run-inlining.cc#newcode235
test/cctest/compiler/test-run-inlining.cc:235: "function foo(s) { x.y =
9; return 42; };"
You could use "return x.y" here as an additional verification that the
assignment really was ignored.
https://codereview.chromium.org/515103002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
